fix ColumnHelper['accessor'] TValue type#5999
Open
Smona wants to merge 1 commit intoTanStack:mainfrom
Open
Conversation
2 tasks
Author
|
@KevinVandy any changes you would like to see here? we've been using this type in our codebase for a while now without issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4382
I ran into #4382 trying to write a generic, reusable wrapper around react-table. Looking into the issue brought me to the
ColumnHelpertype. I've had issues in the past when trying to transform one generic type parameter into a second, inferred generic parameter, and often it can be fixed using a distributive helper type instead. So I tried pulling out theTValuegeneric parameter into one, and then using that inColumnHelperinstead.This seems to work! I'm able to create a properly typed, generic reusable wrapper component by defining the props like this:
And the types are compatible, with no types lost: